For anyone who does a lot of git commits this is so true http://xkcd.com/1296/
Mine get better. *shrug* I have a really hard time explaining what I'm doing from a blank slate. Productivity increases as well.
- OCoG of FF, Jimminy
Heh, Jimminy, my commits have a flow where they get more explanatory as I add features and then get a lot more vague as I am troubleshooting the same bug or problem for the 5th time
- Scoble, Alex Scoble
For bugs I generally do: "Fix [issue] in class::method" Occassionally add descriptive text past the commit title. I usually ignore the diff when writing commits. So they do get less explanatory, but still useful enough.
- OCoG of FF, Jimminy
The most non-explanatory line in my logs for my current projects: "Flesh out index"
- OCoG of FF, Jimminy
Yeah, I'd say that half the time, a detailed explanation of a change is pretty unnecessary. People can do a diff if they really want to know where you added that single comma.
- Scoble, Alex Scoble
LOL, "Add comma to by-line"
- OCoG of FF, Jimminy
If the comma was actually important for execution, it shouldn't have been committed in the first place. :P
- OCoG of FF, Jimminy
Because you never make mistakes?
- Scoble, Alex Scoble
In Puppet there are times when you need commas in a list, hash or array and times when you don't. Sometimes I forget which is where when I'm creating new modules.
- Scoble, Alex Scoble
Alex, because if it doesn't run, or pass the tests, it doesn't get committed until it's fixed. But I drop comma's by accident on occasion, they're just always fixed before a commit.
- OCoG of FF, Jimminy
Ahh, yeah, we aren't that mature yet...getting something like Jenkins up and running is something I need to do within the year
- Scoble, Alex Scoble
Jenkins is easy to set up. I have set up a couple of instances at work.
- imabonehead
Present tense, Cristo. :P "Clean up code" Just noticed the comic failed at that, too.
- OCoG of FF, Jimminy
But it's not imperative. [1] I should probably use bullet points, now that I'm thinking about it, because there's always the possibility of someone doing something that collapses whitespace. Normally I just use a hanging indent. Though listed points usually only fall under subheadings REASONS:, TODO:, or FIXES: with a hanging indent. [1] http://tbaggery.com/2008...
- OCoG of FF, Jimminy
Why am I arguing with Cristo, when it's Alex's thread?
- OCoG of FF, Jimminy
I don't agree that commit statements should be in present tense because it makes no sense to me to say that I'm doing something that I just did, but I'm not a programmer.
- Scoble, Alex Scoble
Then again it appears that even programmers disagree on whether to use present or past tense when doing a commit. Anyhow, just because present tense was Linus' choice, doesn't mean I need to adhere to it, because grammatically, it doesn't make sense.
- Scoble, Alex Scoble
I guess the question revolves around whether the commit message explains what the commit does, or what was done in the commit. Religious wars for the win!
- Scoble, Alex Scoble
You just ask this question: "What will the commit do: It will [imperative clause]" "What does the commit do: It [declarative clause]". Either way, you're not supposed to talk about yourself.
- OCoG of FF, Jimminy
We can never work together. Your syntax is wrong. :P I don't care that much, but personally I do stick to it, and have immediately run --amend -m to fix the message to be imperative.
- OCoG of FF, Jimminy